Skip to content

fix: Bump appcompat to avoid "OnClickXmlDetector called context.getMainProject()" lint error #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix: Bump appcompat to avoid "OnClickXmlDetector called context.getMainProject()" lint error #974

merged 1 commit into from
Sep 15, 2021

Conversation

barbeau
Copy link
Collaborator

@barbeau barbeau commented Sep 14, 2021

Closes #973

@arriolac This avoids #973 when running lint on the demo app which should allow the semantic release to pass. It bumps to an alpha version of appcompat to avoid an apparent compatibility issue with AGP7 and the latest stable release for appcompat (v1.3.1), but given that the demo app is using the dependency (and not the library) it shouldn't affect library stability.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/

Fixes #973 🦕

@barbeau barbeau requested a review from arriolac September 14, 2021 22:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
arriolac
arriolac approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barbeau barbeau merged commit dbfdbc7 into main Sep 15, 2021
@barbeau barbeau deleted the sean/fix-appcompat branch September 15, 2021 19:06
googlemaps-bot pushed a commit that referenced this pull request Sep 15, 2021
@semantic-release-bot
chore(release): 2.2.6 [skip ci]
94663c3 
## [2.2.6](v2.2.5...v2.2.6) (2021-09-15)

### Bug Fixes

* MapObjectManager.Collection object order ([#972](#972)) ([e6276a9](e6276a9)), closes [#846](#846)
* Update appcompat to avoid "OnClickXmlDetector called context.getMainProject()" lint error ([#974](#974)) ([dbfdbc7](dbfdbc7))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@arriolac arriolac arriolac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@arriolac arriolac

Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantic release build is failing with "OnClickXmlDetector called context.getMainProject()"
3 participants
@barbeau @googlemaps-bot @arriolac