Skip to content

fix: fixed the javadoc task and errors #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix: fixed the javadoc task and errors #1148

merged 1 commit into from
Jan 18, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Jan 18, 2023

The following PR fixes the Javadoc tasks.

This has been broken for some time, since at least the version 2.2.5 (probably due to a Gradle or AGP update).

This PR fixes the current javadoc Gradle task, and removes some of its errors (specifically, using the closing <p/> tag.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Edit the title of this pull request with a semantic commit prefix (e.g. "fix: "), which is necessary for automated release workflows to decide whether to generate a new release and what type it should be.
  • [ X Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@kikoso kikoso added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 18, 2023
@kikoso kikoso requested a review from wangela January 18, 2023 13:33
@wangela wangela merged commit 2f0320f into main Jan 18, 2023
@wangela wangela deleted the fix/fixed_javadoc_tasks branch January 18, 2023 17:30
googlemaps-bot pushed a commit that referenced this pull request Jan 18, 2023
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
0a9ddea 
## [3.1.1](v3.1.0...v3.1.1) (2023-01-18)

### Bug Fixes

* fix the javadoc task and errors ([#1148](#1148)) ([2f0320f](2f0320f))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kikoso @googlemaps-bot @wangela