Skip to content

fix: Ensure CameraPositionState map reference clears when GoogleMap leaves composition. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arriolac wants to merge 1 commit into from
Closed

fix: Ensure CameraPositionState map reference clears when GoogleMap leaves composition. #108

arriolac wants to merge 1 commit into from

Conversation

@arriolac
Copy link
Contributor

@arriolac arriolac commented May 5, 2022 •
edited
Loading

Fixes the issue where the CameraPositionState maintains a reference to a GoogleMap when it is hoisted. The previous implementation did not appropriately clean up after the GoogleMap composable leaves the composition.

TODO:

  • Write unit test

Fixes #106 🦕

@arriolac
fix: Ensure CameraPositionState map reference clears when GoogleMap l…
e8c5bd0 
…eaves composition.

Change-Id: Iccf615e1a468ea7fbddb652052cec51b5d98a763
@arriolac arriolac requested a review from barbeau May 5, 2022 04:20
@arriolac
Copy link
Contributor Author

arriolac commented May 5, 2022

Closing in favor of #109

@arriolac arriolac closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbeau barbeau Awaiting requested review from barbeau

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"CameraPositionState may only be associated with one GoogleMap at a time" when used with Accompanist's HorizontalPager

1 participant

@arriolac