Merged
Conversation
kikoso
force-pushed
the
feat/dataset_styling_samples
branch
from
a172372 to
b8a4697
Compare
kikoso
changed the title
Collaborator
Author
|
@stephenmcd , what do you think about uploading the source files for the datasets? They are publicly available in institutional sites and linked from our documentation, would it be ok to have them here on GitHub as well? |
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
kikoso
force-pushed
the
feat/dataset_styling_samples
branch
from
d57783f to
5114122
Compare
kikoso
force-pushed
the
feat/dataset_styling_samples
branch
from
10b4d45 to
1a097f6
Compare
Collaborator
Author
|
@dkhawk , I have checked the new behavior of the fix for the DDS, and it seems to work. PR has been updated, feel free to take a look. |
This commit introduces data-driven styling for datasets in the ApiDemos application. The following changes were made: Added a custom Application class (ApiDemoApplication) to check for the presence and validity of the API key during startup. Added a new data structure (DataSet) to hold information about each dataset, including its label, dataset ID, location, and styling callback. Updated the DataDrivenDatasetStylingActivity to use the new data structure and styling callbacks. Rename the dataset input files to better reflect there contents.
* Makes the app look better on full screen with a cutout * Uses material elements * Switch to using secrets for the data set ids * more of a convenience to prevent having to remove the ids when submitting * moves dataset data files to common area since they are not used directly by the app * Detailed instructions for uploading the data to console (WIP)
dkhawk
approved these changes
Feb 13, 2025
googlemaps-bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
# [1.15.0](v1.14.0...v1.15.0) (2025-02-13) ### Features * Data-Driven styling samples ([#1771](#1771)) ([f4654e6](f4654e6))
Contributor
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds the samples for the Data-Driven styling for datasets and boundaries.
Three source files have been added based on the documentation provided by the examples. The source file for Seattle no longer works, so the uploaded one is the file that worked when the documentation was written.
DataDrivenDatasetStylingActivityandDataDrivenBoundariesActivity.DataDrivenDatasetStylingActivityrequires the user to replaceYOUR-DATASET-IDwith their dataset id.