This repository was archived by the owner on May 15, 2023. It is now read-only.
Added string() to metric labels for printing and added const metric strings.#73
Open
evanSpendlove wants to merge 2 commits intomasterfrom
Open
Added string() to metric labels for printing and added const metric strings.#73evanSpendlove wants to merge 2 commits intomasterfrom
evanSpendlove wants to merge 2 commits intomasterfrom
Conversation
evanSpendlove
requested review from
alicjakwie,
cianbgoog,
deniadelcid and
leczb
leczb
suggested changes
Sep 18, 2020
|
|
||
| // String returns the ProbeOperation as a string. | ||
| func (p ProbeOperation) String() string { | ||
| return ProbeOpName[p] |
There was a problem hiding this comment.
Nit: if this is the only usage of ProbeOpName, then make it non-exported.
|
|
||
| // String returns the APICall as a string. | ||
| func (a APICall) String() string { | ||
| return APICallName[a] |
| ) | ||
|
|
||
| func (e ExitStatus) String() string { | ||
| return ExitStatusName[e] |
| AllFilesMissing: "all_files_missing", | ||
| } | ||
|
|
||
| ProbeLatency = "hermes_probe_latency_seconds" |
| } | ||
|
|
||
| ProbeLatency = "hermes_probe_latency_seconds" | ||
| APILatency = "hermes_api_latency_Seconds" |
| m.ProbeOpLatency[op][e] = metrics.NewEventMetrics(time.Now()). | ||
| AddMetric("hermes_probe_latency_seconds", probeOpLatDist.Clone()). | ||
| AddMetric(ProbeLatency, probeOpLatDist.Clone()). | ||
| AddLabel("storage_system", target.GetTargetSystem().String()). |
| if err != nil { | ||
| mp.logger.Errorf(err.Error()) | ||
| t.LatencyMetrics.ProbeOpLatency[metrics.TotalProbeRun][exitStatus].Metric("latency").AddFloat64(time.Now().Sub(start).Seconds()) | ||
| t.LatencyMetrics.ProbeOpLatency[metrics.TotalProbeRun][exitStatus].Metric("hermes_probe_latency_seconds").AddFloat64(time.Now().Sub(start).Seconds()) |
cianbgoog
reviewed
Sep 18, 2020
| @@ -161,10 +161,10 @@ func (mp *Probe) runProbe(ctx context.Context, metricChan chan<- *cpmetrics.Even | |||
| exitStatus, err := mp.runProbeForTarget(probeCtx, t) | |||
| if err != nil { | |||
| mp.logger.Errorf(err.Error()) | |||
There was a problem hiding this comment.
Not related to this change, but you should add some context to this error.
cianbgoog
approved these changes
Sep 18, 2020
cianbgoog
left a comment
cianbgoog
left a comment
There was a problem hiding this comment.
Happy to LGTM, assuming you fix all leczb's comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.