This repository was archived by the owner on May 15, 2023. It is now read-only.
Open
Conversation
GCS and the CreateFile function takes the right arguments
moved the code responsible for mocking gcs to a different file (mock_gcs.go) Restructured packages Implemented table driven tests for TestFileName All tests pass
Moved the storage mocking components of create_file_test to a shared file (mock_gcs.go) Exported the necessary functions for create_file_test
alicjakwie
requested review from
cianbgoog,
deniadelcid,
evanSpendlove and
leczb
leczb
suggested changes
Sep 16, 2020
hermes/probe/mock/mock_gcs.go
Outdated
| return &fakeClient{buckets: map[string]*fakeBucket{}} | ||
| } | ||
|
|
||
| func (o fakeObjectHandle) NewWriter(context.Context) stiface.Writer { |
There was a problem hiding this comment.
Recommend using pointers for receivers in general.
Although this method doesn't modify the receiver, I would still use a pointer, as it's cheaper.
cianbgoog
approved these changes
Sep 16, 2020
Co-authored-by: Evan Spendlove <43849980+evanSpendlove@users.noreply.github.com>
Co-authored-by: Evan Spendlove <43849980+evanSpendlove@users.noreply.github.com>
Co-authored-by: Evan Spendlove <43849980+evanSpendlove@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the storage mocking components of create_file_test to a shared file (mock_gcs.go)
Exported the necessary functions for create_file_test