Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for hashed token router #950

Merged
merged 2 commits into from
May 14, 2024
Merged

Add test for hashed token router #950

merged 2 commits into from
May 14, 2024

Conversation

XAMPPRocky
Copy link
Collaborator

No description provided.

@Jake-Shadle Jake-Shadle marked this pull request as ready for review May 14, 2024 11:45
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 328b42b7-6a54-479e-9c54-4f31263c3b1d

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/950/head:pr_950 && git checkout pr_950
cargo build

.into(),
);

clusters.build_token_maps();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe happen through a watcher task in quilkin instead, to prevent a code path where the token maps aren't built from ever happening.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it does create them automatically when endpoint sets are updated in a proxy, this function call is just exposed since tests/benches aren't doing the normal operation but I suppose I could change it so that they're either built like they are now, or else when accessed, the issue would be that if they're built on access in actual running code that would be expensive.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I guess it's fine for now.

@XAMPPRocky XAMPPRocky merged commit 0f1f5bc into main May 14, 2024
11 checks passed
@markmandel markmandel deleted the ep/fix-hash-router branch May 14, 2024 18:04
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants