Add clippy to ci and fix warnings

[iffyio]

Fixes #82

[iffyio]

Added context for the less obvious diffs

[iffyio]

@markmandel could you take a look at why the build fails in ci I don't have viewing permissions 😊

[markmandel]

Already have image (with digest): gcr.io/quilkin/ci
error: 'cargo-clippy' is not installed for the toolchain '1.42.0-x86_64-unknown-linux-gnu'
To install, run `rustup component add clippy --toolchain 1.42.0-x86_64-unknown-linux-gnu`

And added you as viewer! When we are ready for this to go open, I'll set it up so that the build results are more public.

[markmandel]

Sounds like we would want to add clippy here:
https://github.com/googleforgames/quilkin/blob/master/ci/Dockerfile

Then I can rebuild the ci image and push it up 👍

[iffyio]

Updated dockerfile.

[markmandel]

And rebuilt. Let's try it again!

[markmandel]

That looks better:

error: You matched a field with a wildcard pattern. Consider using `..` instead
   --> src/config.rs:156:17
    |
156 |                 connection_id: _,
    |                 ^^^^^^^^^^^^^^^^
    |
note: lint level defined here
   --> src/lib.rs:17:9
    |
17  | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(clippy::unneeded_field_pattern)]` implied by `#[deny(warnings)]`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern

error: You matched a field with a wildcard pattern. Consider using `..` instead
   --> src/config.rs:157:17
    |
157 |                 lb_policy: _,
    |                 ^^^^^^^^^^^^
    |
    = help: Try with `Client { addresses, .. }`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern

error: aborting due to 2 previous errors

error: could not compile `quilkin`.

To learn more, run the command again with --verbose.

We are getting Clippy warnings now!

[markmandel]

Looks like there is a bug with Cloud Build integration where it only points to the first build. If you go to the build history, you can see the latest version.

(I've filed a bug)

[markmandel]

I'm not seeing those warnings locally - wondering if we should also update our rust version at the same time?

[markmandel]

Nice changes. Had a few questions along the way, but overall 👍

[markmandel]

New image is up! New build re-running at:
http://console.cloud.google.com/cloud-build/builds/d5dabc66-6e67-4ac4-b293-6d90f8c8bc14;step=2?project=quilkin

[markmandel]

Got a test failure :( Can repro it locally too.

---- config::tests::parse_server stdout ----
thread 'config::tests::parse_server' panicked at 'called `Result::unwrap()` on an `Err` value: Message("no variant of enum ConnectionConfig found in flattened data", Some(Pos { marker: Marker { index: 10, line: 3, col: 5 }, path: "." }))', src/config.rs:307:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    config::tests::parse_server

test result: FAILED. 40 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

[markmandel]

👍