Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #846

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Minor cleanup #846

merged 4 commits into from
Nov 3, 2023

Conversation

Jake-Shadle
Copy link
Collaborator

  • Remove dirs2 and atty
  • Cleanup deny config
  • Use std::io::IsTerminal instead of atty
  • Fix compile errors when instrument feature is enabled

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:
Fixes some extremely low hanging fruit after doing a cargo deny --all-features check and cargo clippy --all-features

@Jake-Shadle
Remove dirs2 and atty
1cb9abe 
dirs2 was unused and atty is unmaintained and can be replaced
with std::io::IsTerminal

Also auto-formatted the manifest
@Jake-Shadle
Cleanup deny
97861ad 
Several configs for crates not in the graph, constrain the targets to
realistic ones to not bother checking platforms that don't matter for
production
@Jake-Shadle
Use std::io::IsTerminal instead of atty
a043f97
@Jake-Shadle
Fix compile errors when instrument feature is enabled
1446891
@github-actions github-actions bot added the size/s label Nov 3, 2023
@XAMPPRocky XAMPPRocky enabled auto-merge (squash) November 3, 2023 11:37
@XAMPPRocky
Copy link
Collaborator

Hmm seems that test is flaky 🤔

@XAMPPRocky XAMPPRocky merged commit 0ee3ffe into main Nov 3, 2023
5 checks passed
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: d1f2d8bf-a1e8-4f83-8ab2-296e711ae56f

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/846/head:pr_846 && git checkout pr_846
cargo build

@Jake-Shadle Jake-Shadle deleted the cleanup branch November 3, 2023 13:33
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky XAMPPRocky approved these changes

@markmandel markmandel Awaiting requested review from markmandel markmandel is a code owner

@koslib koslib Awaiting requested review from koslib koslib is a code owner

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jake-Shadle @XAMPPRocky @quilkin-bot @markmandel