Reorganise modules #824
Merged
Reorganise modules #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
force-pushed
the
ep/reorg
branch
2 times, most recently
from
b5a83a4
to
34be2b6
Compare
markmandel
approved these changes
Oct 16, 2023
XAMPPRocky
force-pushed
the
ep/reorg
branch
2 times, most recently
from
6af22f6
to
ced114a
Compare
Since this is just a refactoring, should we be concerned there is still an issue with Sockets / Socket mapping in here? |
While working on adding delta xDS I was finding a lot of our module organisation to be quite messy and there was clear groupings of functionality. This commit doesn't make any functional changes it only changes the layout of the following modules. * proxy -> cli::proxy * utils -> codec::base64 (Loggable trait moved to lib.rs) * prost -> codec::prost * protocol -> codec::qcmp * ttl_map -> collections::ttl * endpoint -> net::endpoint * metadata -> net::endpoint::metadata * xds -> net::xds * test_utils -> test
|
Build Succeeded 🥳 Build Id: 9b7347be-b1a2-48d2-9ea8-0a97fb99c3cd The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding delta xDS I was finding a lot of our module organisation to be quite messy and there wasn't clear groupings of functionality.
This commit doesn't make any functional changes it only changes the layout of the following modules.