Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Distroless based on Debian 12 #805

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Updated base image, which includes a fix to mark the binary as owned by the nonroot user.

Which issue(s) this PR fixes:

Various bits and pieces I'm finding while working through #772

Special notes for your reviewer:

Building the Docker image is working on CI, but without the --chown=nonroot:nonroot it refused to work for me locally (permission error), rather odd!

Either way, this updates everything 🤞🏻

Updated base image, which includes a fix to mark the binary as owned
by the nonroot user.
@markmandel markmandel added area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc labels Sep 29, 2023
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 9e64f98e-7b2c-4788-947b-91e9119a49cd

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/805/head:pr_805 && git checkout pr_805
cargo build

@XAMPPRocky XAMPPRocky merged commit 2f182ab into googleforgames:main Sep 29, 2023
3 checks passed
@markmandel markmandel deleted the update/distroless branch September 29, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants