fix timestamp warnings #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
markmandel
reviewed
Sep 18, 2023
| @@ -70,7 +70,7 @@ impl Ping { | |||
| } | |||
| }; | |||
|
|
|||
| let recv_time = chrono::Utc::now().timestamp_nanos(); | |||
| let recv_time = chrono::Utc::now().timestamp_nanos_opt().unwrap(); | |||
There was a problem hiding this comment.
Is there any risk of timestamp_nanos_opt() returning None ?
There was a problem hiding this comment.
Only if people are still running Quilkin in a couple hundred years. https://docs.rs/chrono/latest/chrono/struct.DateTime.html#method.timestamp_nanos_opt
An i64 with nanosecond precision can span a range of ~584 years. This function panics on an out of range DateTime.
The dates that can be represented as nanoseconds are between 1677-09-21T00:12:44.0 and 2262-04-11T23:47:16.854775804.
markmandel
approved these changes
Sep 18, 2023
|
Build Succeeded 🥳 Build Id: 290c3a92-4c46-47ac-8e44-5d63389b9957 The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preventing all other PRs from succeeding.