Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --idle-request-interval-secs #790

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Add --idle-request-interval-secs #790

merged 2 commits into from
Sep 18, 2023

Conversation

XAMPPRocky
Copy link
Collaborator

This PR adds a new flag to both relay and load balancer services.

--idle-request-interval-secs adds a timeout for waiting for responses, so that if the service hasn't heard back from a management server in the specified time it will send a request for new resources. This should help catch any spurious errors where a service is unresponsive but the HTTP connection is active, since the request failing will trigger a new HTTP connection.

@markmandel markmandel enabled auto-merge (squash) September 18, 2023 21:23
@markmandel markmandel merged commit de49889 into main Sep 18, 2023
5 checks passed
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 4cc3e5e5-237c-4e07-b02d-e330f1d789e1

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/790/head:pr_790 && git checkout pr_790
cargo build

@markmandel markmandel deleted the ep/grpc-checkin branch September 18, 2023 22:25
@markmandel markmandel added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/feature New feature or request size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants