Remove shutdown_rx from downstream loop #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
This was referenced May 26, 2023
markmandel
approved these changes
Jul 5, 2023
|
Build Succeeded 🥳 Build Id: 23e07a56-6b8d-4fb6-8656-31d369b6a118 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
added
kind/feature
swermin
pushed a commit
to swermin/quilkin
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of having better
SIGTERMhandling, I noticed the shutdown could potentially still affect traffic because it shut down the main downstream socket recv loop