Improve server delete logic #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
force-pushed
the
ep/improve-removal
branch
from
24f78b3
to
b791d1b
Compare
XAMPPRocky
force-pushed
the
ep/improve-removal
branch
from
b791d1b
to
297fc0c
Compare
XAMPPRocky
force-pushed
the
ep/improve-removal
branch
from
297fc0c
to
0a6abab
Compare
|
Build Succeeded 🥳 Build Id: 52c54f59-090a-4c9a-b2d5-dbfe60035d56 The following development images have been built, and will exist for the next 30 days: To build this version: |
markmandel
approved these changes
Apr 24, 2023
markmandel
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is improvement on #729 as I noticed we weren't always catching every valid server to delete.