Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug line for cli parameters #706

Merged
merged 1 commit into from
Feb 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const ETC_CONFIG_PATH: &str = "/etc/quilkin/quilkin.yaml";
const PORT_ENV_VAR: &str = "QUILKIN_PORT";

/// The Command-Line Interface for Quilkin.
#[derive(clap::Parser)]
#[derive(Debug, clap::Parser)]
#[command(version)]
#[non_exhaustive]
pub struct Cli {
Expand All @@ -68,7 +68,7 @@ pub struct Cli {
}

/// The various Quilkin commands.
#[derive(Clone, clap::Subcommand)]
#[derive(Clone, Debug, clap::Subcommand)]
pub enum Commands {
Proxy(Proxy),
GenerateConfigSchema(GenerateConfigSchema),
Expand Down Expand Up @@ -108,6 +108,8 @@ impl Cli {
"Starting Quilkin"
);

tracing::debug!(cli = ?self, "config parameters");

let config = Arc::new(Self::read_config(self.config)?);
let _admin_task = self
.command
Expand Down
2 changes: 1 addition & 1 deletion src/cli/generate_config_schema.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

/// Generates JSON schema files for known filters.
#[derive(clap::Args, Clone)]
#[derive(clap::Args, Clone, Debug)]
pub struct GenerateConfigSchema {
/// The directory to write configuration files.
#[clap(short, long, default_value = ".")]
Expand Down
2 changes: 1 addition & 1 deletion src/cli/manage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ define_port!(7800);

/// Runs Quilkin as a xDS management server, using `provider` as
/// a configuration source.
#[derive(clap::Args, Clone)]
#[derive(clap::Args, Clone, Debug)]
pub struct Manage {
/// One or more `quilkin relay` endpoints to push configuration changes to.
#[clap(short, long, env = "QUILKIN_MANAGEMENT_SERVER")]
Expand Down
2 changes: 1 addition & 1 deletion src/cli/proxy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use crate::filters::FilterFactory;
define_port!(7777);

/// Run Quilkin as a UDP reverse proxy.
#[derive(clap::Args, Clone)]
#[derive(clap::Args, Clone, Debug)]
pub struct Proxy {
/// One or more `quilkin manage` endpoints to listen to for config changes
#[clap(short, long, env = "QUILKIN_MANAGEMENT_SERVER", conflicts_with("to"))]
Expand Down
2 changes: 1 addition & 1 deletion src/cli/relay.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pub const PORT: u16 = 7900;
/// (mDS) for accepting cluster and configuration information from xDS
/// management services, and exposing it as a single merged xDS service for
/// proxy services.
#[derive(clap::Args, Clone)]
#[derive(clap::Args, Clone, Debug)]
pub struct Relay {
/// Port for mDS service.
#[clap(short, long, env = "QUILKIN_MDS_PORT", default_value_t = PORT)]
Expand Down