Error for invalid endpoint #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than searching for a string in an error message, this creates an Error type for when an xDS endpoint address is invalid. `http::Uri` will allow some Uri formats that will fail for us, so we also add some extra checks of our own to ensure we have all the information we need to make a connection.
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
|
Build Succeeded 🥳 Build Id: aae22907-ce48-4e9f-9b66-cfe949441e0d The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Rather than searching for a string in an error message, this creates an Error type for when an xDS endpoint address is invalid.
http::Uriwill allow some Uri formats that will fail for us, so we also add some extra checks of our own to ensure we have all the information we need to make a connection.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A