Timeout for xDS gRPPC Client connection #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't seem to find any default timeout for connection from a tonic gRPC connection - which leads me to think it will block forever. This might be the cause of why there is only a single retry in googleforgames#660, but at the very least, we should have a timeout anyway, just in case a connection ends up deadlocking for whatever reason. Work on googleforgames#660
markmandel
requested review from
XAMPPRocky,
No-ops,
rezvaneh and
vallfors
as code owners
markmandel
commented
Dec 14, 2022
| .map_err(RpcSessionError::InitialConnect), | ||
| Some(endpoint) => { | ||
| let endpoint = Endpoint::from_shared(endpoint) | ||
| .map_err(RpcSessionError::InitialConnect)? |
There was a problem hiding this comment.
One thought I had here - if we can't create an endpoint, we could return a specific error that ends up with RetryPolicy::Break in the try_hard section - rather than the string check of "invalid url" - but wanted to check before implementing. I think we end up in the same place, since if an Endpoint can't be created, we can't ever connect. WDYT?
There was a problem hiding this comment.
That makes sense to me.
XAMPPRocky
approved these changes
Dec 14, 2022
|
Build Succeeded 🥳 Build Id: 9e4811f4-0731-4812-a6de-36c54cd08a5b The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
I can't seem to find any default timeout for connection from a tonic gRPC connection - which leads me to think it will block forever.
This might be the cause of why there is only a single retry in #660, but at the very least, we should have a timeout anyway, just in case a connection ends up deadlocking for whatever reason.
Which issue(s) this PR fixes:
Work on #660
Special notes for your reviewer: