Flatten proxy config section into root #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
requested review from
markmandel,
No-ops,
rezvaneh and
vallfors
as code owners
XAMPPRocky
force-pushed
the
ep/flatten-proxy
branch
from
80609cf
to
c0142f7
Compare
XAMPPRocky
force-pushed
the
ep/flatten-proxy
branch
2 times, most recently
from
7118d41
to
a270e2b
Compare
markmandel
reviewed
Oct 14, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Mark Mandel <markmandel@google.com>
XAMPPRocky
force-pushed
the
ep/flatten-proxy
branch
from
4be9657
to
fd01416
Compare
markmandel
reviewed
Oct 18, 2022
agones/src/xds.rs
Outdated
| @@ -67,6 +67,7 @@ mod tests { | |||
|
|
|||
| let config = r#" | |||
| version: v1alpha1 | |||
| admin: null | |||
There was a problem hiding this comment.
admin: null shouldn't be required. Are you seeing it fail without this line?
markmandel
approved these changes
Oct 20, 2022
|
Build Succeeded 🥳 Build Id: 3b95f6f7-3ed8-466b-8c8f-887bbad5e25b The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clear that
portandidcan refer a management server's port and id, not just a proxy's. Also added management server'sportflag.