Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar Example README: Switch to relative paths #617

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Just to avoid fragility with updates to examples breaking past release examples, I switched the README on this example to using relative links, so that people didn't end up being directed to pull from main, which will likely break at some point.

Which issue(s) this PR fixes:

Work on #546

Special notes for your reviewer:

N/A

Just to avoid fragility with updates to examples breaking past release
examples, I switched the README on this example to using relative links,
so that people didn't end up being directed to pull from main, which
will likely break at some point.

Work on googleforgames#546
@markmandel markmandel added kind/documentation Improvements or additions to documentation area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 10, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: dcb21a71-191c-4440-be85-5ea48c604a52

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/617/head:pr_617 && git checkout pr_617
cargo build

@XAMPPRocky XAMPPRocky merged commit b5f5ed3 into googleforgames:main Oct 10, 2022
@markmandel markmandel deleted the examples/sidecar-readme branch October 10, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Improvements or additions to documentation size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants