Allow gameservers to not have port

[XAMPPRocky]

When gameservers are deleted, their port is removed. This fixes it so that the gameserver will have a port of zero instead of returning an error.

[markmandel]

🤔 on deletion I don't think we remove anything from the status part of the GameServer CRD (there's no reason to) in Agones. I should go double check though.

I wonder what is causing Quilkin to see this.

[quilkin-bot]

Build Succeeded 🥳

Build Id: 80d5b952-8970-4406-be72-01df960c11dc

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/598/head:pr_598 && git checkout pr_598
cargo build

[markmandel]

So double checked:

On shutdown we don't remove anything on Agones:

https://github.com/googleforgames/agones/blob/a980e896da9ba73b4a52f4a99754dc479a0b95cb/pkg/gameservers/controller.go#L869-L883

When we find a deletion timestamp we don't remove anything either:

https://github.com/googleforgames/agones/blob/a980e896da9ba73b4a52f4a99754dc479a0b95cb/pkg/gameservers/controller.go#L413-L452

So not sure what's causing this in the CRD, but it might be on the Quilkin side. Would be worth investigating.

[XAMPPRocky]

@markmandel Interesting, it doesn't happen all the time, it happens some of the time, I'll log the output and post here.

[markmandel]

Sounds good. Let's merge this though!

[markmandel]

Figure it would be good to have a fix in, and then we can also look to a potentially better solution over time.