Implementation of endpoint_send_filter #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes passing the FilterChain into the Session, so that is can call endpoint_send_filter when sending data out through the endpoint. Work on #1
markmandel
added
kind/feature
iffyio
reviewed
Jun 9, 2020
src/server/sessions.rs
Outdated
| session.send_to(msg.as_bytes()).await.unwrap(); | ||
| assert_eq!(msg, wait.await.unwrap()); | ||
|
|
||
| // with a filters |
There was a problem hiding this comment.
'filters' should be 'filter' ?
src/server/sessions.rs
Outdated
| return self.send.send_to(data.as_slice(), &self.dest.address).await; | ||
| } | ||
|
|
||
| Ok(0) |
There was a problem hiding this comment.
Could we change the return type for this function to e.g Result<Option<size>> or similar enum that would allow the caller to differentiate between a dropped packet and a packet without payload (that could have size 0?)? In the drop case the returned value would be e.g Ok(None) so that we won't have to worry about cases where size 0 might be special.
There was a problem hiding this comment.
Strong agree on this one, indeed.
There was a problem hiding this comment.
Excellent suggestion. Will jump on it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes passing the FilterChain into the Session, so that is can
call endpoint_send_filter when sending data out through the endpoint.
Work on #1