Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use htmltest binary not build from source #516

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

We just got a new release of htmltest, so we no longer need to build the binary from source. Shrinks the time to build the build image by quite a bit, as we don't have as much work to do.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

We just got a new release of htmltest, so we no longer need to build the
binary from source.  Shrinks the time to build the build image by quite
a bit, as we don't have as much work to do.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. labels Apr 13, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 0eab45d2-4a6a-4cb1-9fb3-a979e08855a1

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/516/head:pr_516 && git checkout pr_516
cargo build

@XAMPPRocky XAMPPRocky merged commit 604469d into googleforgames:main Apr 13, 2022
@markmandel markmandel deleted the cleanup/htmltest branch April 14, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. kind/cleanup Refactoring code, fixing up documentation, etc size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants