Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pass & Drop filters, Refactor Match config #472

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

XAMPPRocky
Copy link
Collaborator

@XAMPPRocky XAMPPRocky commented Jan 24, 2022

This adds simple "pass" and "drop" filters, that either always allow a packet to pass, or always drop a packet. These filters aren't useful on their own, but become useful when used in combination with conditional flow filters like Match (#447).

closes #454

@markmandel
Copy link
Member

Only question I have: Did we want to include the documentation with these Filters in this PR, or should it come as a separate? (if separate, let's track that in an issue, so we don't forget).

Otherwise, LGTM!

@XAMPPRocky
Copy link
Collaborator Author

I've added documentation, and I've also refactored a small bit of Matches, I've now renamed it to Match, and I've updated it from having special cased Pass and Drop branches in its configuration, if you want to drop or pass a packet, you should use the Pass and Drop filters. This simplifies some of the configuration.

@markmandel Would nice to get this in the next release, so that it's not technically a breaking change.

@XAMPPRocky XAMPPRocky force-pushed the pass-and-drop branch 2 times, most recently from dde10bf to 43f3148 Compare February 4, 2022 12:57
@XAMPPRocky XAMPPRocky changed the title Add Pass & Drop filters Add Pass & Drop filters, Refactor Match config Feb 4, 2022
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 275f4fa7-dea0-4a5c-bbf0-65badb82f000

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/472/head:pr_472 && git checkout pr_472
cargo build

pub mod firewall;
pub mod load_balancer;
pub mod local_rate_limit;
pub mod matches;
pub mod r#match;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non blocking): I assume the r# is because match is a keyword?

@markmandel markmandel merged commit b5193ea into main Feb 23, 2022
@markmandel markmandel deleted the pass-and-drop branch February 23, 2022 19:51
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New feature or request labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc kind/cleanup Refactoring code, fixing up documentation, etc kind/feature New feature or request size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Matches to Match.
3 participants