-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pass & Drop filters, Refactor Match
config
#472
Conversation
49230e4
to
0805281
Compare
Only question I have: Did we want to include the documentation with these Filters in this PR, or should it come as a separate? (if separate, let's track that in an issue, so we don't forget). Otherwise, LGTM! |
0805281
to
4e35397
Compare
I've added documentation, and I've also refactored a small bit of @markmandel Would nice to get this in the next release, so that it's not technically a breaking change. |
dde10bf
to
43f3148
Compare
Match
config
43f3148
to
13738b6
Compare
13738b6
to
1911c79
Compare
1911c79
to
97d03d4
Compare
Build Succeeded 🥳 Build Id: 275f4fa7-dea0-4a5c-bbf0-65badb82f000 To build this version:
|
pub mod firewall; | ||
pub mod load_balancer; | ||
pub mod local_rate_limit; | ||
pub mod matches; | ||
pub mod r#match; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non blocking): I assume the r#
is because match
is a keyword?
This adds simple "pass" and "drop" filters, that either always allow a packet to pass, or always drop a packet. These filters aren't useful on their own, but become useful when used in combination with conditional flow filters like
Match
(#447).closes #454