Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove slog and replace with tracing #457

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

XAMPPRocky
Copy link
Collaborator

With the release of https://github.com/tokio-rs/console I wanted to move over to tracing sooner rather than later, so this pulls out all instances of slog and replaces them with tracing.

resolves #317

@XAMPPRocky XAMPPRocky changed the title Completely remove slog and replace with tracing Completely remove slog and replace with tracing Dec 23, 2021
@XAMPPRocky
Copy link
Collaborator Author

@markmandel Failure seems unrelated to the PR, not sure how to fix it.

@markmandel
Copy link
Member

@markmandel Failure seems unrelated to the PR, not sure how to fix it.

That's a weird one. When in doubt, retry.

@markmandel
Copy link
Member

Looks like I can't re-run a build older than three days.

Easy way to rerun a build if you don't want to go to the console is: git commit --amend --date=now and then push that over the top. It'll fire a whole new build.

@XAMPPRocky
Copy link
Collaborator Author

@markmandel FWIW, I wrote that comment after retrying twice. I'll push an empty commit in the next couple days (on holidays)

@markmandel
Copy link
Member

@markmandel FWIW, I wrote that comment after retrying twice. I'll push an empty commit in the next couple days (on holidays)

AAAH. I can't tell anymore, because no history 😄 Sounds like I'll need try this locally and see if I can find where things are broken in the build system 👍🏻 No worries, I'll get on it tomorrow most likely.

@markmandel
Copy link
Member

I worked it out! Since we no longer have slog-json, we don't have any MPL source code to grab, so the zip doesn't get created!

I'll come up with a fix in my draft branch, and you can include it in the PR 👍🏻

@markmandel
Copy link
Member

Got it!

You will need to update image/archive_dependencies.sh like so (markmandel@b6c7550), since slog-json is no longer a dependency.

I figure it would make more sense to be included in your PR, since the removal of slog is tied to this PR, rather than as a separate PR.

markmandel added a commit to markmandel/quilkin that referenced this pull request Jan 10, 2022
If there are no dependencies utilised that we need to archive source for,
this breaks the build process since no dependencies-src.zip file is
created, and the Dockerfile has nothing to copy.

This changes the script such that it starts with an empty zip file, and
then appends dependencies if and when they exist.

Unblocks googleforgames#457
markmandel added a commit that referenced this pull request Jan 11, 2022
If there are no dependencies utilised that we need to archive source for,
this breaks the build process since no dependencies-src.zip file is
created, and the Dockerfile has nothing to copy.

This changes the script such that it starts with an empty zip file, and
then appends dependencies if and when they exist.

Unblocks #457
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e7e504fd-899d-457c-9528-72cee2e7ac61

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/457/head:pr_457 && git checkout pr_457
cargo build

@markmandel markmandel merged commit 1cfb23a into main Jan 11, 2022
@markmandel markmandel deleted the replace-slog branch January 11, 2022 20:15
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from slog to tracing
4 participants