Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for nightly in CI and developer guide #352

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Remove need for nightly in CI and developer guide #352

merged 1 commit into from
Aug 6, 2021

Conversation

markmandel
Copy link
Member

Now that we've upgraded to rust 1.54.0, we no longer need to use +nightly to run our document tests!

@markmandel
Remove need for nightly in CI and developer guide
be82755 
Now that we've upgraded to rust 1.54.0, we no longer need to use
`+nightly` to run our document tests!
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. labels Aug 5, 2021
@google-cla google-cla bot added the cla: yes label Aug 5, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c5b057aa-6faf-45de-a4fc-cbee1b0fc9e0

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/352/head:pr_352 && git checkout pr_352
cargo build

@XAMPPRocky XAMPPRocky merged commit f013092 into googleforgames:main Aug 6, 2021
@markmandel markmandel deleted the build/remove-nightly branch August 6, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky XAMPPRocky approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @quilkin-bot @XAMPPRocky