Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs/cleanup in netcat quickstart #322

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Bugs/cleanup in netcat quickstart #322

merged 2 commits into from
Jul 8, 2021

Conversation

markmandel
Copy link
Member

  • Remove the note about macOS, since we have that as a release binary
    now
  • Fix the Quilkin config since we no longer have names on endpoints.

Work on #313

@markmandel
Bugs/cleanup in netcat quickstart
f7f2b76 
* Remove the note about macOS, since we have that as a release binary
  now
* Fix the Quilkin config since we no longer have names on endpoints.

Work on #313
@markmandel markmandel added kind/bug Something isn't working kind/documentation Improvements or additions to documentation kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 7, 2021
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 045b0aa9-5ac6-42cb-99a4-1268a10c1d0a

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/322/head:pr_322 && git checkout pr_322
cargo build

@markmandel markmandel added this to the Release milestone Jul 7, 2021
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: ff53f239-7be2-4861-8c6b-64a59ed08e2e

To build this version:

git fetch git@github.com:googleforgames/quilkin.git pull/322/head:pr_322 && git checkout pr_322
cargo build

@markmandel markmandel merged commit 90aa0dd into main Jul 8, 2021
@markmandel markmandel deleted the docs/cleanup-netcat branch July 8, 2021 17:34
XAMPPRocky pushed a commit that referenced this pull request Jul 21, 2021
@markmandel @XAMPPRocky
Bugs/cleanup in netcat quickstart (#322)
90f2717 
* Remove the note about macOS, since we have that as a release binary
  now
* Fix the Quilkin config since we no longer have names on endpoints.

Work on #313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XAMPPRocky XAMPPRocky XAMPPRocky approved these changes

Assignees
No one assigned
Labels
cla: yes kind/bug Something isn't working kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Improvements or additions to documentation
Projects
None yet
Milestone
Release
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @quilkin-bot @XAMPPRocky