Add rust-toolchain.toml to project #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a rust-toolchain.toml to the project that matches the current build system's rust version. Also includes a section in our CONTRIBUTING.md discussing the reason for the Rust versioning and how to ensure the correct version is installed. Work on #241
markmandel
added
kind/feature
markmandel
commented
May 12, 2021
| We target a specific version of Rust for each build, so we can be deliberate when changing versions to | ||
| track if there are any performance changes between Rust releases. | ||
|
|
||
| Run `rustup show` in the root of the project directory to install the rust toolchain that is standard for Quilkin |
There was a problem hiding this comment.
Please let me know if there is a better way to do this -- documentation wasn't very clear, and this was the only way that worked for me.
There was a problem hiding this comment.
Well it might not be clear, because it should be automatic. If you run cargo build or any other tool in the directory and don’t have the toolchain it should automatically download.
There was a problem hiding this comment.
That's what I expected, but when I ran cargo build this didn't seem to work for me. 🤔 This was the only command that I found that effectively adhered to the right tooling.
There was a problem hiding this comment.
I just tried it - and of course cargo commands just work now 🤦🏻
XAMPPRocky
approved these changes
May 12, 2021
iffyio
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a rust-toolchain.toml to the project that matches the current build system's rust version.
Also includes a section in our CONTRIBUTING.md discussing the reason for the Rust versioning and how to ensure the correct version is installed.
Work on #241