xds fail fast on invalid URI #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than retry. Also pass a struct with all resource handlers to the client rather than individually. This allows us to easily add the listener handler later. Work on #10
markmandel
reviewed
Dec 15, 2020
src/test_utils.rs
Outdated
| @@ -362,6 +364,19 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Awaits the provided future with a timeout. | |||
| /// Returns the future's result or None after the timeout elapses. | |||
| pub async fn await_with_timeout<T>(fut: impl Future<Output = T>, timeout: Duration) -> Option<T> { | |||
There was a problem hiding this comment.
Over the holidays, I finally found: https://docs.rs/tokio/0.2.24/tokio/time/fn.timeouthtml
Should we switch to this instead, rather than write our own?
markmandel
reviewed
Dec 15, 2020
markmandel
reviewed
Dec 15, 2020
markmandel
added
area/user-experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than retry.
Also pass a struct with all resource handlers to the client rather
than individually. This allows us to easily add the listener handler later.
Work on #10