Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use builder to create Config #109

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Use builder to create Config #109

merged 2 commits into from
Oct 13, 2020

Conversation

iffyio
Copy link
Collaborator

@iffyio iffyio commented Sep 19, 2020

So that whenever Config's fields are updated, we don't
need to go through the codebase to updating every usage.

@iffyio
Use builder to create Config
13a3507 
So that whenever Config's fields are updated, we don't
need to go through the codebase to updating every usage.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 12, 2020
markmandel
markmandel approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@markmandel markmandel merged commit 22d5298 into master Oct 13, 2020
@markmandel markmandel deleted the iu/config-builder branch October 13, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iffyio @markmandel @googlebot