Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include image built in PR on CI Bot Result #593

Closed
markmandel opened this issue Sep 17, 2022 · 1 comment · Fixed by #599
Closed

Include image built in PR on CI Bot Result #593

markmandel opened this issue Sep 17, 2022 · 1 comment · Fixed by #599
Assignees
@markmandel
Labels
area/build-tools Development tooling. kind/feature New feature or request

Comments

@markmandel
Copy link
Member

markmandel commented Sep 17, 2022 •
edited
Loading

Below is an example of a build failure.

It would be super handy to publish the image tag in the below description that was built and tested, such that if you wanted to reproduce a failing test (or temporarily use an image from a PR from a successful build), you would be able to do so, without having to build the image yourself.

(Also should check the image is publically available).

I don't think we have any automation for CI image cleanup at this stage, but we could guarantee an image stays around for 30 days.

Build Failed 😭

Build Id: 2a3889cc-8364-48a5-9e18-a1a90ad2b524

Status: FAILURE

To get permission to view the Cloud Build view, join the quilkin-discuss Google Group.

Originally posted by @quilkin-bot in #574 (comment)
@markmandel markmandel mentioned this issue Sep 20, 2022
Merged
markmandel added a commit to markmandel/quilkin that referenced this issue Sep 21, 2022
@markmandel
Add Build Images to CI results.
fa4c067 
Added the image artifacts to successful builds.

Since Cloud Build doesn't track pushed images on failure (and the image
may/may not exist depending on where it failed) I can only provide
directions on how to search for the image after the fact.

Closes googleforgames#593
markmandel added a commit to markmandel/quilkin that referenced this issue Sep 21, 2022
@markmandel
Add Build Images to CI results.
2843775 
Added the image artifacts to successful builds.

Since Cloud Build doesn't track pushed images on failure (and the image
may/may not exist depending on where it failed) I can only provide
directions on how to search for the image after the fact.

Closes googleforgames#593
@markmandel markmandel self-assigned this Sep 21, 2022
@markmandel
Copy link
Member Author

Started working on this.

Since Cloud Build doesn't tag image artifacts on failure, we'll have to rely on the Cloud console search interface to find a debug image, if it exists.

@markmandel markmandel mentioned this issue Sep 21, 2022
Merged
markmandel added a commit to markmandel/quilkin that referenced this issue Sep 21, 2022
@markmandel
Add Build Images to CI results.
7f5e379 
Added the image artifacts to successful builds.

Since Cloud Build doesn't track pushed images on failure (and the image
may/may not exist depending on where it failed) I can only provide
directions on how to search for the image after the fact.

Closes googleforgames#593
@markmandel markmandel added kind/feature New feature or request area/build-tools Development tooling. labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
area/build-tools Development tooling. kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Build Images to CI results markmandel/quilkin
1 participant
@markmandel