Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove name field from Endpoint objects #152

Closed
iffyio opened this issue Dec 5, 2020 · 0 comments · Fixed by #160
Closed

Remove name field from Endpoint objects #152

iffyio opened this issue Dec 5, 2020 · 0 comments · Fixed by #160
Labels
good first issue Good for newcomers kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@iffyio
Copy link
Collaborator

iffyio commented Dec 5, 2020

The name field on endpoints isn't used for any functionality currently, also endpoints provided by XDS do not include a corresponding field either - we should be able to delete this field.
@iffyio iffyio added good first issue Good for newcomers kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 5, 2020
iffyio added a commit that referenced this issue Dec 14, 2020
@iffyio
Endpoint metadata support from static config
ff4ba45 
Parses generic yaml key values into a json value and in order to
use as the endpoint's metadata.
Values under the `quilkin.dev` key is reserved for quilkin usage.
Extracts token into the endpoint object since we don't want to traverse
the json value on each lookup.
Removes name and connection ID from the static Endpoint config struct.

Work on #10
Fixes #152
iffyio added a commit that referenced this issue Dec 14, 2020
@iffyio
Endpoint metadata support from static config
4d16bd3 
Parses generic yaml key values into a json value and in order to
use as the endpoint's metadata.
Values under the `quilkin.dev` key is reserved for quilkin usage.
Extracts token into the endpoint object since we don't want to traverse
the json value on each lookup.
Removes name and connection ID from the static Endpoint config struct.

Work on #10
Fixes #152
@iffyio iffyio mentioned this issue Dec 14, 2020
Merged
markmandel pushed a commit that referenced this issue Jan 13, 2021
@iffyio
Endpoint metadata support from static config (#160)
0cd6eb4 
* Endpoint metadata support from static config

Parses generic yaml key values into a json value and in order to
use as the endpoint's metadata.
Values under the `quilkin.dev` key is reserved for quilkin usage.
Extracts token into the endpoint object since we don't want to traverse
the json value on each lookup.
Removes name and connection ID from the static Endpoint config struct.

Work on #10
Fixes #152

* Rename token key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Endpoint metadata support from static config googleforgames/quilkin
1 participant
@iffyio