Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for front link. Not sure what happened? #772

Merged
merged 2 commits into from
May 23, 2019

Conversation

markmandel
Copy link
Member

Front page has What is Agones? An open source, batteries-included, mulitplayer dedicated game server scaling and orchestration platform that can run anywhere [Kubernetes](https://kubernetes.io) can run. displaying 🤦‍♂️

@markmandel markmandel added kind/bug These are bugs. area/site The website itself - including redirects, styling, search, etc labels May 15, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 81c2b854-492f-4295-96c5-019d6546176d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/772/head:pr_772 && git checkout pr_772
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-fd665a2

@roberthbailey
Copy link
Member

It's strange that the opencensus link works fine as markdown but the k8s one doesn't.

There aren't many snapshots of agones.dev in the waybackmachine, but from what I can tell this has been broken for at least a few weeks (e.g. not new with the 0.10 release).

@markmandel markmandel marked this pull request as ready for review May 16, 2019 02:05
@markmandel
Copy link
Member Author

I wonder if it was when I upgraded hugo a while back - and it had this strange effect? 🤷‍♂️

@roberthbailey
Copy link
Member

lgtm

also, needs rebase

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9e04f66f-c244-42af-b5fd-1049a1bba58c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9b5faac8-0a3f-400f-a42e-5f7f1b09e691

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Not quite sure why this is failing. Fixing locally and force pushing back up.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 236ff899-fd10-4f33-bd3a-b399a30b73ee

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@pooneh-m
Copy link
Contributor

pooneh-m commented May 22, 2019

Not quite sure why this is failing. Fixing locally and force pushing back up.

All PRs are failing. I ran e2e tests locally and all passed.

@markmandel
Copy link
Member Author

I restarted consul, see if that is the issue. Very confusing, because there doesn't seem to be anything in the logs indicating what is the actual issue. Consul is the only thing I could think of.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 67142124-2a16-422e-8a79-eb2ef9f621ad

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

So I have seen this specific error in a few e2e tests failing

--- FAIL: TestAllocator (37.12s)
    allocator_test.go:74: 
        	Error Trace:	allocator_test.go:74
        	Error:      	Expected nil, but got: &url.Error{Op:"Post", URL:"https://34.83.164.122:443/v1alpha1/gameserverallocation", Err:(*net.OpError)(0xc00062f590)}
        	Test:       	TestAllocator

I'm wondering if there is a race condition in there - or maybe there should be a backoff.

@markmandel
Copy link
Member Author

Adding a test for flakiness, and seeing if I can find the root cause over here:
#789

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f1386a60-2879-4af2-b2bd-a4e2e344c01c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5d44e7ca-5d51-458d-a550-483fc87558e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/772/head:pr_772 && git checkout pr_772
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-3657501

@pooneh-m pooneh-m merged commit 8f4b40a into googleforgames:master May 23, 2019
@markmandel markmandel deleted the site/front-link branch May 23, 2019 16:47
@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/site The website itself - including redirects, styling, search, etc kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants