Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image build and manifest push process #4118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0xaravindh
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Works on #3978

Special notes for your reviewer:

@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/S labels Feb 25, 2025
@0xaravindh 0xaravindh self-assigned this Feb 25, 2025
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 7b59a234-6ffc-438a-a057-e6980c1f88a1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4118/head:pr_4118 && git checkout pr_4118
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-1ebe0d9

@0xaravindh 0xaravindh marked this pull request as ready for review March 6, 2025 05:28
@igooch
Copy link
Collaborator

igooch commented Mar 10, 2025

@kangjk1017 do you have the ability pull, build & test the PR to see if it works on your windows nodes?

@0xaravindh and I do not have the ability to test on windows nodes. However, a fetch of this branch, local build, & push to a non-public artifact registry has a manifest with os.version for windows:

{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3233,
         "digest": "sha256:df4fb05be305c3fa708e94ba52f87ad67c62d7f961af86c4dace4d69aa9c2ef0",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 3039,
         "digest": "sha256:3290ff57551de10ed0171ad2b64e600a6034116c6cb9b53170f6230130c2ac62",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1101,
         "digest": "sha256:b3b687763426470a2fb2288c42784d1dc79a041b4934709574f2db6019c4524e",
         "platform": {
            "architecture": "amd64",
            "os": "windows",
            "os.version": "10.0.17763.6893"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 1101,
         "digest": "sha256:b23a3a3aaac009f189a9c87ecd2bf314ec55da57caf35525602ef84ae3f567d7",
         "platform": {
            "architecture": "amd64",
            "os": "windows",
            "os.version": "10.0.20348.3207"
         }
      }
   ]
}

@kangjk1017
Copy link

Thank you very much. It works perfectly.
I was able to run containers on both Linux and Windows nodes using the sidecar image us-docker.pkg.dev/agones-images/ci/agones-sdk:1.48.0-dev-1ebe0d9.
Unfortunately, aside from using this built image, I’m in a difficult position to test anything else on my own.

Thank you again so much for all your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants