Adding Fleet Active GameServerSet Percentage Metrics

[0xaravindh]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes: #3663

Closes #3663

Special notes for your reviewer:

[agones-bot]

Build Failed 😭

Build Id: cfa78591-f21a-4ef7-b788-64edd441876f

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 🥳

Build Id: a4f0265c-59e0-41a5-a4cd-ab29381d9b0c

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-000872c
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-000872c
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-000872c-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-000872c
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-000872c
• Linux C++ SDK (build): agonessdk-1.45.0-dev-000872c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.45.0-dev-000872c.zip

A preview of the website (the last 30 builds are retained):

• https://000872c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4021/head:pr_4021 && git checkout pr_4021
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-000872c

[peterzhongyi]

How should I verify that the newly added metric is working as intended? Is there some test that covers it, or can I perform some series of actions to verify the metric is working in the dashboard? If so, can you add to the description of the pr?

[0xaravindh]

@peterzhongyi For additional guidance, refer to PR #3663, where Mark provided helpful suggestions that I have followed closely.

[agones-bot]

Build Succeeded 🥳

Build Id: 126b88be-5d05-44c5-a174-bacf455d4d48

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-0a00781
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-0a00781
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-0a00781-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-0a00781
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-0a00781
• Linux C++ SDK (build): agonessdk-1.45.0-dev-0a00781-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.45.0-dev-0a00781.zip

A preview of the website (the last 30 builds are retained):

• https://0a00781-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4021/head:pr_4021 && git checkout pr_4021
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-0a00781

[gongmax]

@0xaravindh would you like to test your change by following https://agones.dev/site/docs/guides/metrics/#installation to install prometheus and grafana locally and see whether the new added metrics shows up?

[agones-bot]

Build Failed 😭

Build Id: e9783c89-b541-41e5-be81-aca7e55b611c

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[0xaravindh]

@0xaravindh would you like to test your change by following https://agones.dev/site/docs/guides/metrics/#installation to install prometheus and grafana locally and see whether the new added metrics shows up?

@gongmax I’ve tested it by following the guide to install Prometheus and Grafana locally, and the new metrics are showing up correctly in gs dashboard. do you think stats are looking enough? or should I include any additional data in that field?