Old kern writer: Convert groups back #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madig
force-pushed
the
fix-kerning-pair-conversion
branch
from
5968262 to
d3eeee0
Compare
|
I don't understand the test failure... it werks on my local machine? Is there a accidental un-sorting problem hiding in there? |
|
You could try re running the CI manually |
anthrotype
reviewed
May 24, 2024
|
Ah yes, running it multiple times locally makes it crash occasionally. Let's see. |
|
feel free to merge this when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an oversight in #841.
The kerning pair sides have to be converted back to fea AST classes. Since groups aren't filtered in
getVariableKerningPairs, it should hopefully be okay to just grab them by their members 😬