Skip to content

Possible logic error in getScriptLanguageSystems #822

Open
@cmyr

Description

@cmyr

On the following line in this function, the sc value may be None, but this case does not appear to be handled, which means that the returned map could contain an unexpected None value.

The called function currently returns None if the tag is DFLT, which we skip earlier in this function so this is probably fine? but future changes might break this, and it might make sense to check this value before inserting it in the map.

sc = unicodedata.ot_tag_to_script(script)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions