Skip to content

flattenComponents breaks composed positioning on nested + transformed combining accent #435

Closed
@arrowtype

Description

@arrowtype

I have attempted to use the flattenComponents filter in a UFO based on the advice here: fonttools/fontbakery#2961 (comment)

<key>com.github.googlei18n.ufo2ft.filters</key>
    <array>
      <dict>
        <key>name</key>
        <string>flattenComponents</string>
        <key>pre</key>
        <integer>1</integer>
      </dict>
    </array>

It mostly works well! However, a notable exception is that my caroncomb accents, which are actually composed of the circumflexcomb rotated 180°. These caroncombs are decomposed, which is good, but the alignment in glyphs using them gets messed up once I use FontMake to export to a TTF:

misaligned flattened components

image

By comparison, here is a TTF built from a UFO that didn’t have a flattenComponents filter:

good components alignment

These are not open-source UFOs, so I can try to report back later with an OS reproduction case, if that is needed to diagnose & fix this problem.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions