Cut instances in the Noto recipe provider #1030
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FWIW, I think the win metrics are not supposed to get updated. We have a FB check that complains if members of a family don't share the same win metrics. |
Contributor
Author
|
That's GF policy, yes. But it's not OT spec. If the masters do have varying win metrics, then in general a static instance cutter should update them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now I've done various bits of optimisation, a good chunk of the time of a Noto build is caught up in instantiating UFOs in order to build static TTFs. I'd like to move towards cutting instances from VFs (that's what the front-end does, so it should be acceptable)...
However, this is currently draft because there are some differences between the cut instances and the UFO-instantiated builds, listed below. So we probably need a
gftools-cut-instancewhich fixes up the problems, and use that instead of purely callinghb-subset.winAscentandwinDescentare not updated, neither withfontTools varLib.instancerorhb-subset.hb-subsetdoes not correct the macStyle and fsSelection bits for bold weights, leading to problems with style linking. (fontTools OK here).notdefglyphs withhb-subset. (fontTools OK here)hb-subsetdoes not update the name table (fontTools does).