[fea-rs] Fix validation of ss01-ss20 & cv01-cv99 #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our validation code was broken in a subtle way, where we were skipping the first statement in the block if it wasn't one of the special statements. This fixes that, and also fixes a possible deadlock in the parsing of the cvParameters block.
rsheeter
approved these changes
Oct 3, 2024
rsheeter
added this to the 100 families pass ttx_diff in default and gftools mode milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our validation code was broken in a subtle way, where we were skipping the first statement in the block if it wasn't one of the special statements.
This fixes that, and also fixes a possible deadlock in the parsing of the cvParameters block.
This gets at least one more font compiling.