Tweak is_nonspacing_mark_name based on flamegraph #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before change is_nonspacing_mark reports as ~4% of total time and a major part of GlyphIrWork:
Essentially all the time was spent on partial eq for str so in this PR I try to avoid that by exiting early when the str could not possibly match.
After change it reports as ~1.5% and while still visible it no longer dominates GlyphIrWork:
Tested using Oswald.