Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preallocate some buffers based on flamegraph #393

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Preallocate some buffers based on flamegraph #393

merged 1 commit into from
Aug 15, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Aug 10, 2023

Before, fontcglyphs2fontir::toir::to_ir_contours_and_components (1 samples, 0.92%)` showing the usual vec growth fns.
After, can't find to_ir_contours_and_components in the flamegraph for GlyphIrWork at all.

Also avoid the clone in src_path.nodes.clone().

@rsheeter rsheeter changed the title [WIP] Preallocate some buffers based on flamegraph Preallocate some buffers based on flamegraph Aug 15, 2023
@rsheeter rsheeter marked this pull request as ready for review August 15, 2023 03:22
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@rsheeter rsheeter merged commit 700e79e into main Aug 15, 2023
8 checks passed
@rsheeter rsheeter deleted the fg branch August 15, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants