[ttx_diff] More cleanup #1058
Merged
[ttx_diff] More cleanup #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Oct 18, 2024
resources/scripts/ttx_diff.py
Outdated
| cmd_string = " ".join(str(c) for c in cmd) | ||
| eprint(f" (cd {working_dir} && {cmd_string})") | ||
| eprint(f" (cd {cwd} && {cmd_string})") |
There was a problem hiding this comment.
cd None would look weird, maybe don't echo cd something if cwd is None?
- Improve some type annotations - rename 'run' to 'log_and_run' - use kwargs to forward more args to subprocss.run - use subprocess.run timeout arg instead of gnu timeout
cmyr
force-pushed
the
ttx-more-cleanup
branch
from
2452254
to
bf9d753
Compare
anthrotype
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JMM