[ttx_diff] Simplify reuse logic #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
approved these changes
Oct 18, 2024
anthrotype
reviewed
Oct 18, 2024
anthrotype
approved these changes
Oct 18, 2024
At the beginning of the run, we now check the 'rebuild' flag, and explicitly delete anything we are required to rebuild. This lets us simplify later logic by knowing we're allowed to reuse anything that exists. This is part of a larger refactor to support the CI use case; because CI builds each individual font in a transient temporary directory, these artifacts do not persist between runs. To reuse artifacts CI is going to need to start storing these artifacts somewhere other than in the build directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning of the run, we now check the 'rebuild' flag, and explicitly delete anything we are required to rebuild. This lets us simplify later logic by knowing we're allowed to reuse anything that exists.
This is part of a larger refactor to support the CI use case; because CI builds each individual font in a transient temporary directory, these artifacts do not persist between runs. To reuse artifacts CI is going to need to start storing these artifacts somewhere other than in the build directory.