This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Performance fix for loading data into paged table. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when user clicks next page on a paged table, it downloads ALL data for that table which makes it very slow on clicking "next page" the first time. Also it consumes memory expectedly. The fix adds the offset and count to the query so only the data needed is downloaded.
yebrahim
approved these changes
Oct 10, 2016
ojarjur
approved these changes
Oct 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when user clicks next page on a paged table, it downloads ALL data for
that table which makes it very slow on clicking "next page" the first
time. Also it consumes memory unexpectedly. The fix adds the offset and
count to the query so only the data needed is downloaded.