Update the stackdriver getting started notebook. #32
Conversation
supriyagarg
force-pushed
the
stackdriver_getting_started
branch
2 times, most recently
from
d3323c8 to
eb134dc
Compare
|
@ojarjur: This PR is passing the travis tests in my github account, but failing here. See below: Failing: https://travis-ci.org/googledatalab/notebooks/builds/163565845 vs Passing: https://travis-ci.org/supriyagarg/notebooks/builds/163565840 Is there some setting I am missing? |
|
@supriyagarg You're hitting a security feature of Travis. Travis won't allow the required environment variables to be used in the build since the This is all intentional, and the work around is to do exactly what you've done; set up Travis builds on your fork repository. Even though GitHub will show those tests as failing a repository administrator (either myself or Nikhil) can still merge the change. Alternatively, you can create pull requests from a feature branch in this same repository, but you shouldn't think of that as being required. |
|
Thanks for the clarification @ojarjur! I didn't run into this issue with pydatalab, so the behavior confused me. But yes, the notebooks repo needs the service account key, so this makes sense. |
supriyagarg
force-pushed
the
stackdriver_getting_started
branch
9 times, most recently
from
0955acd to
9ece4d6
Compare
supriyagarg
force-pushed
the
stackdriver_getting_started
branch
from
9ece4d6 to
c551908
Compare
|
@ojarjur: This PR is now approved, and passes Travis tests on my fork. Can you please help with the merging. Thanks! |
| @@ -112,7 +112,7 @@ | |||
| "### Stackdriver Monitoring\n", | |||
| "\n", | |||
| "The tutorials for this module use a sample project. This project is not readable by everyone. In order to execute the tutorials, you will have to set a default project, and make sure that it has at least one GCE Instance.\n", | |||
| "* [**Getting Started**](tutorials/Monitoring/Getting started.ipynb) - Cloud Datalab allows you to access and analyze the monitoring data. For an overview of how to access the timeseries data, start here." | |||
| "* [**Getting Started**](tutorials/Stackdrivering Monitoring/Getting started.ipynb) - Cloud Datalab allows you to access and analyze the monitoring data. For an overview of how to access the timeseries data, start here." | |||
There was a problem hiding this comment.
Change "Stackdrivering" to "Stackdriver"
The notebook is modified so that it handles projects with a large number of GCE instances better. Instead of showing the timeseries for all instances, the notebook now does so for instances matching a given prefix. Also, the output of the help is updated to reflect the underlying code changes.
supriyagarg
force-pushed
the
stackdriver_getting_started
branch
from
c551908 to
e2d9f5e
Compare
The notebook is modified so that it handles projects with a large number
of GCE instances better. Instead of showing the timeseries for all
instances, the notebook now does so for instances matching a given
prefix.
Also, the output of the help is updated to reflect the underlying code
changes.