This repository was archived by the owner on Sep 3, 2022. It is now read-only.
Replace 127.0.0.1's with localhost to support IPv6-only machines. #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running on machines with no IPv4 interface, 127.0.0.1 is not a useful IP or interface name. localhost on the other hand is ~universally useful for the same concept, and works equally well on each of IPv4-only, IPv6-only, and dual-stack machines. This change replaces 3 explicit usages of "127.0.0.1" and two implicit ones (hiding behind the default or null arguments to tcp-port-used's functions. b/35224793
ojarjur
approved these changes
Feb 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on machines with no IPv4 interface, 127.0.0.1 is not a useful IP or
interface name. localhost on the other hand is ~universally useful for the same
concept, and works equally well on each of IPv4-only, IPv6-only, and dual-stack
machines.
This change replaces 3 explicit usages of "127.0.0.1" and two implicit ones
(hiding behind the default or null arguments to tcp-port-used's functions.
b/35224793