Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Remove the keyboard shortcut to move cells up/down from the documentation #1010

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Remove the keyboard shortcut to move cells up/down from the documentation #1010

merged 1 commit into from
Oct 10, 2016

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 8, 2016

Closes #777

The following keyboard shortcuts are no longer supported in Jupyter Notebook 4.2:

  • Ctrl+K - move cell up
  • Ctrl+J - move cell down

I've confirmed that the other keyboard shortcuts documented in Datalab are still functional.

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Did the shift+tab quick help work for you? It doesn't for me on Chrome/Mac

@parthea
Copy link
Contributor Author

parthea commented Oct 8, 2016

@yebrahim Thanks for reviewing this!

Yes, I was able to get the quick help to work on Ubuntu/Chrome. I haven't tried Mac.

Can you try the following steps?

  • In otherwise empty cell, run the following:
import datalab.bigquery as bq
  • Type bq.Query in a new cell. With the cursor at the end of bq.Query, try the shift+tab shortcut.
    quickhelp

@nikhilk
Copy link
Contributor

nikhilk commented Oct 9, 2016

A notebook is in two modes - command mode (cell is selected) and edit mode (code cell is activated). Things like shortcuts to move cells only apply to command mode.

@parthea
Copy link
Contributor Author

parthea commented Oct 9, 2016

Note: The keyboard shortcut to move cells up/down has been removed from Jupyter (ipython/ipython#7732).

@yebrahim
Copy link
Contributor

This is a shame, I wonder why they're taking it away! Thanks for the fix.

@yebrahim yebrahim merged commit 8f97aa4 into googledatalab:master Oct 10, 2016
@parthea parthea deleted the issues/issue_777 branch October 10, 2016 14:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants