This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Fix: Codelabs UI was not starting due to gulpfile and task updates#915
Open
zarinlo wants to merge 4 commits intogooglecodelabs:mainfrom
Open
Fix: Codelabs UI was not starting due to gulpfile and task updates#915zarinlo wants to merge 4 commits intogooglecodelabs:mainfrom
zarinlo wants to merge 4 commits intogooglecodelabs:mainfrom
Conversation
mco-gh
approved these changes
Sep 23, 2024
zarinlo
commented
Oct 2, 2024
Contributor
Author
zarinlo
left a comment
zarinlo
left a comment
There was a problem hiding this comment.
Updated the gulpfile tasks and packages needed version upgrades in package.json file. Updated the helper functions used by gulp in /helpers/opts.js as well.
mco-gh
reviewed
Oct 2, 2024
Contributor
mco-gh
left a comment
mco-gh
left a comment
There was a problem hiding this comment.
@DragonRider0o0 Any chance you can approve this?
Morehman27
approved these changes
Oct 12, 2024
Contributor
Author
|
Thank you Marc and Mo!
Is anyone else able to review, it still needs one more peer review before
it can be merged: #915
- Zarin
…On Sat, Oct 12, 2024 at 5:49 PM Morehman27 ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#915 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDDTOS3MSESJJG5ELVE6HTZ3GKNBAVCNFSM6AAAAABN5YD3BCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRUGU4DEMZQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sitefolder needed heavy updates given it is very behindsite/codelabsfolder for demo purposesTo run Codelabs UI:
pm installnpm install -g gulp-cligulp serve --codelabs-dir=codelabsPreview