-
Notifications
You must be signed in to change notification settings - Fork 61
Bump kustomize, run gomod.sh and add changes to support it #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
02ccf49
to
159c9e6
Compare
8cf4484
to
d80717a
Compare
Pre-emptive postsubmit run: https://github.com/googlecloudrobotics/core/actions/runs/7046754782/job/19179184047 FAILED. :(
Not merging yet |
Signed-off-by: methylDragon <methylDragon@google.com>
Signed-off-by: methylDragon <methylDragon@google.com>
ae36a22
to
4aeadef
Compare
Signed-off-by: methylDragon <methylDragon@google.com>
Signed-off-by: methylDragon <methylDragon@google.com>
4aeadef
to
d1f4015
Compare
@ensonic This looks good to me, but I don't want to unilaterally approve it since this is a bit invasive |
@ensonic please pay special attention to: https://github.com/googlecloudrobotics/core/pull/266/files#diff-3286564e7e043d6e73c09671c2a1a0c5d6fa6873ed217491774e2339cf8a062bR14-R23 Latest relevant postsubmit manual run passes: https://github.com/googlecloudrobotics/core/actions/runs/7053793632 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this for now :/
Signed-off-by: methylDragon <methylDragon@google.com>
I need all dependencies (including transitive ones) to use
k8s.io/client-go
v0.27+The old version of kustomize/api uses v0.20.4:
https://github.com/kubernetes-sigs/kustomize/blob/api/v0.13.4/cmd/depprobcheck/go.mod#L57
Bumping it makes it use v0.27.0:
https://github.com/kubernetes-sigs/kustomize/blob/api/v0.15.0/cmd/depprobcheck/go.mod#L59
I really really hope this is the last one
I also realize I didn't run
gomod.sh
in the previous PR. So I ran it here.