Skip to content

Bump kustomize, run gomod.sh and add changes to support it #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Nov 30, 2023

I need all dependencies (including transitive ones) to use k8s.io/client-go v0.27+

The old version of kustomize/api uses v0.20.4:
https://github.com/kubernetes-sigs/kustomize/blob/api/v0.13.4/cmd/depprobcheck/go.mod#L57

Bumping it makes it use v0.27.0:
https://github.com/kubernetes-sigs/kustomize/blob/api/v0.15.0/cmd/depprobcheck/go.mod#L59

I really really hope this is the last one

I also realize I didn't run gomod.sh in the previous PR. So I ran it here.

@methylDragon methylDragon requested a review from ensonic November 30, 2023 11:10
@methylDragon methylDragon force-pushed the ch3/bump-kustomize branch 3 times, most recently from 02ccf49 to 159c9e6 Compare November 30, 2023 12:06
@methylDragon
Copy link
Contributor Author

methylDragon commented Nov 30, 2023

@ensonic note I had to change the sources to support the bumps.
Some dependencies had type/signature changes.

d80717a

@methylDragon methylDragon changed the title Bump kustomize Bump kustomize, run gomod.sh and add changes to support it Nov 30, 2023
@methylDragon methylDragon requested a review from ensonic November 30, 2023 12:53
@methylDragon
Copy link
Contributor Author

methylDragon commented Nov 30, 2023

Pre-emptive postsubmit run: https://github.com/googlecloudrobotics/core/actions/runs/7046754782/job/19179184047

FAILED. :(

Step #1: --- FAIL: TestKubernetesRobotClusterStatus (0.00s)
Step #1:     k8s_integration_test.go:219: Robot cluster robco-integration-test-robot: Creating the kubernetes client set failed: The gcp auth plugin has been removed.
Step #1:         Please use the "gke-gcloud-auth-plugin" kubectl/client-go credential plugin instead.
Step #1:         See https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke for further details
Step #1: FAIL
Step #1: FAIL: //src/go/tests:go_default_test (see /builder/home/.cache/bazel/_bazel_builder/eab0d61a99b6696edb3d2aff87b585e8/execroot/cloud_robotics/bazel-out/k8-fastbuild/testlogs/src/go/tests/go_default_test/test.log)
Step #1: [2,478 / 2,480] 1 / 2 tests, 1 failed; Testing //src/go/tests:go_default_test; 1s local

Not merging yet

@methylDragon
Copy link
Contributor Author

methylDragon commented Nov 30, 2023

Trying postsubmit again: Postsubmit

Seems the client-go bump led to some auth deprecations.

Signed-off-by: methylDragon <methylDragon@google.com>
Signed-off-by: methylDragon <methylDragon@google.com>
@methylDragon methylDragon force-pushed the ch3/bump-kustomize branch 11 times, most recently from ae36a22 to 4aeadef Compare December 1, 2023 00:02
Signed-off-by: methylDragon <methylDragon@google.com>
Signed-off-by: methylDragon <methylDragon@google.com>
@vivekbagade
Copy link
Contributor

@ensonic This looks good to me, but I don't want to unilaterally approve it since this is a bit invasive

@methylDragon
Copy link
Contributor Author

methylDragon commented Dec 1, 2023

Copy link
Contributor

@ensonic ensonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now :/

Signed-off-by: methylDragon <methylDragon@google.com>
@methylDragon methylDragon enabled auto-merge (squash) December 1, 2023 23:06
@methylDragon methylDragon merged commit 67d18a2 into main Dec 1, 2023
@methylDragon methylDragon deleted the ch3/bump-kustomize branch December 1, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants